[webkit-changes] [WebKit/WebKit] b65709: [Win][MiniBrowser] Don't show the download dialog ...

Kenji Shukuwa noreply at github.com
Tue Aug 1 05:13:25 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6570992dff1c1d29ccca397f0dd24f016a2edc9
      https://github.com/WebKit/WebKit/commit/b6570992dff1c1d29ccca397f0dd24f016a2edc9
  Author: Kenji Shukuwa <kenji.shukuwa at open-tec.co.jp>
  Date:   2023-08-01 (Tue, 01 Aug 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/WKNavigationResponseRef.cpp
    M Source/WebKit/UIProcess/API/C/WKNavigationResponseRef.h
    M Tools/MiniBrowser/win/WebKitBrowserWindow.cpp

  Log Message:
  -----------
  [Win][MiniBrowser] Don't show the download dialog for subframes.
https://bugs.webkit.org/show_bug.cgi?id=259639

Reviewed by Fujii Hironori.

On some pages, a download dialog is displayed even though the content
is not for download since 266320 at main. Refer to the SOUP port and
we modify it so that it does not download if it is a subframe.

* Source/WebKit/UIProcess/API/C/WKNavigationResponseRef.cpp:
(WKNavigationResponseCopyFrameInfo):
* Source/WebKit/UIProcess/API/C/WKNavigationResponseRef.h:
* Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:
(WebKitBrowserWindow::decidePolicyForNavigationResponse):

Canonical link: https://commits.webkit.org/266471@main




More information about the webkit-changes mailing list