[webkit-changes] [WebKit/WebKit] e9b166: [css-counter-styles] Various small cleanups

Tim Nguyen noreply at github.com
Sun Apr 30 20:58:43 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9b16603c9ebc1bf3127f49b790f0e8bb7fed87b
      https://github.com/WebKit/WebKit/commit/e9b16603c9ebc1bf3127f49b790f0e8bb7fed87b
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-04-30 (Sun, 30 Apr 2023)

  Changed paths:
    M Source/WebCore/css/CSSCounterStyle.cpp
    M Source/WebCore/css/CSSCounterStyleDescriptors.cpp
    M Source/WebCore/css/CSSCounterStyleRegistry.cpp
    M Tools/DumpRenderTree/TestOptions.cpp

  Log Message:
  -----------
  [css-counter-styles] Various small cleanups
https://bugs.webkit.org/show_bug.cgi?id=256155
rdar://108720314

Unreviewed, address Darin's comments on #13320.

- Remove unnecessary `=`
- Add _s suffix to appropriate strings
- Remove unnecessary #include
- Enable @counter-style on Windows DRT (not sure why it was disabled in the first place)

* Source/WebCore/css/CSSCounterStyle.cpp:
(WebCore::CSSCounterStyle::counterForSystemAdditive const):
(WebCore::CSSCounterStyle::counterForSystemSimplifiedChineseInformal):
(WebCore::CSSCounterStyle::counterForSystemSimplifiedChineseFormal):
(WebCore::CSSCounterStyle::counterForSystemTraditionalChineseInformal):
(WebCore::CSSCounterStyle::counterForSystemTraditionalChineseFormal):
* Source/WebCore/css/CSSCounterStyleDescriptors.cpp:
(WebCore::CSSCounterStyleDescriptors::systemCSSText const):
* Source/WebCore/css/CSSCounterStyleRegistry.cpp:
* Tools/DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):

Canonical link: https://commits.webkit.org/263546@main




More information about the webkit-changes mailing list