[webkit-changes] [WebKit/WebKit] d1a666: [css-counter-styles] Enable new codepath for Korea...

Tim Nguyen noreply at github.com
Sun Apr 30 10:04:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d1a6662b8718a56adebfca3e9e79871810a0353d
      https://github.com/WebKit/WebKit/commit/d1a6662b8718a56adebfca3e9e79871810a0353d
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-04-30 (Sun, 30 Apr 2023)

  Changed paths:
    M Source/WebCore/css/CSSCounterStyleRegistry.cpp
    M Source/WebCore/css/counterStyles.css

  Log Message:
  -----------
  [css-counter-styles] Enable new codepath for Korean counter styles
https://bugs.webkit.org/show_bug.cgi?id=256149
rdar://106193134

Reviewed by Myles C. Maxfield.

The spec defines all the Korean counter styles to have two trailing whitespaces for the negative suffix.
Trailing whitespaces in strings seem to be optimized too cleverly by the build system for UA sheets (this bug does not affect author counter styles).

Replace the second whitespace with \20 to make sure the build system doesn't strip the spaces.

This makes the following tests pass with the new codepath:
imported/w3c/web-platform-tests/css/css-counter-styles/korean-hangul-formal/css3-counter-styles-055.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/korean-hanja-formal/css3-counter-styles-065.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/korean-hanja-informal/css3-counter-styles-060.html [ ImageOnlyFailure ]

* Source/WebCore/css/CSSCounterStyleRegistry.cpp:
(WebCore::isCounterStyleUnsupportedByUserAgent):
* Source/WebCore/css/counterStyles.css:
(@counter-style korean-hangul-formal):
(@counter-style korean-hanja-informal):
(@counter-style korean-hanja-formal):

Canonical link: https://commits.webkit.org/263542@main




More information about the webkit-changes mailing list