[webkit-changes] [WebKit/WebKit] f5213f: [IFC] Negative letter-spacing breaks "-webkit-box-...
Alan Baradlay
noreply at github.com
Sun Apr 30 08:35:58 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f5213fdade063ba39c90ac05db3f585092fa4327
https://github.com/WebKit/WebKit/commit/f5213fdade063ba39c90ac05db3f585092fa4327
Author: Alan Baradlay <zalan at apple.com>
Date: 2023-04-30 (Sun, 30 Apr 2023)
Changed paths:
A LayoutTests/fast/inline/webkit-box-decoration-clone-with-negative-letter-spacing-expected.html
A LayoutTests/fast/inline/webkit-box-decoration-clone-with-negative-letter-spacing.html
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
Log Message:
-----------
[IFC] Negative letter-spacing breaks "-webkit-box-decoration-break: clone"
https://bugs.webkit.org/show_bug.cgi?id=256135
<rdar://problem/108701795>
Reviewed by Antti Koivisto.
Trailing decoration was not taken into account when accumulating text content width for content with negative letter spacing.
Let's move out m_contentLogicalWidth logic from [add new], [expand last with/without letter spacing] branches so that introducing a new
branch would not result in the same error.
* LayoutTests/fast/inline/webkit-box-decoration-clone-with-negative-letter-spacing-expected.html: Added.
* LayoutTests/fast/inline/webkit-box-decoration-clone-with-negative-letter-spacing.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::appendTextContent):
Canonical link: https://commits.webkit.org/263540@main
More information about the webkit-changes
mailing list