[webkit-changes] [WebKit/WebKit] 05e01b: Web Inspector: Crash when inspecting CSS Grid with...

[Patrick Angle]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05e01b57a4ecfed9f298898ed78f32bfd2456b94
      https://github.com/WebKit/WebKit/commit/05e01b57a4ecfed9f298898ed78f32bfd2456b94
  Author: Patrick Angle <pangle at apple.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M LayoutTests/inspector/dom/showFlexOverlay.html
    M LayoutTests/inspector/dom/showGridOverlay.html
    M Source/WebCore/inspector/InspectorOverlay.cpp

  Log Message:
  -----------
  Web Inspector: Crash when inspecting CSS Grid without defined columns or rows
https://bugs.webkit.org/show_bug.cgi?id=256072
rdar://108641874

Reviewed by Devin Rousso.

262869 at main fixed issues with determining the authored grid track sizes, but in the process introduced a potential null
pointer deref due to us erroneously trying to get a reference to a RefPtr's value instead of getting its pointer for use
in a dynamic downcast.

* LayoutTests/inspector/dom/showFlexOverlay.html:
- Drive-by ensure we enable all options for flex overlays too so that those paths are exercises.

* LayoutTests/inspector/dom/showGridOverlay.html:
* Source/WebCore/inspector/InspectorOverlay.cpp:
(WebCore::authoredGridTrackSizes):

Canonical link: https://commits.webkit.org/263517@main