[webkit-changes] [WebKit/WebKit] 5eb212: [ iOS ] 2x imported/w3c/web-platform-tests/screen-...

Marcos Cáceres noreply at github.com
Fri Apr 28 12:09:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5eb2125a124bc60c233ce92a636f3cdf0302194d
      https://github.com/WebKit/WebKit/commit/5eb2125a124bc60c233ce92a636f3cdf0302194d
  Author: Marcos Caceres <marcos at marcosc.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/page-visibility/resources/window_state_context.js
    M LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock.html
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/event-before-promise-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document.html
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-basic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/nested-documents-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/nested-documents.html
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe.html
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/resources/orientation-utils.js
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/unlock-expected.txt
    M LayoutTests/platform/ios/TestExpectations

  Log Message:
  -----------
  [ iOS ] 2x imported/w3c/web-platform-tests/screen-orientation are near-constant text failures.
https://bugs.webkit.org/show_bug.cgi?id=255931
rdar://108508861

Reviewed by Chris Dumez.

The cleanup function was accidentally calling "document.screen".
Fixing that revealed a bunch of smaller bugs in the tests.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/page-visibility/resources/window_state_context.js:
(window_state_context.async restore):
(window_state_context):
* LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:
(async if):
(window.test_driver_internal.set_window_rect):
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock.html:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/event-before-promise-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document.html:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-basic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/nested-documents-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/nested-documents.html:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe.html:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/resources/orientation-utils.js:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/unlock-expected.txt:
* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/263509@main




More information about the webkit-changes mailing list