[webkit-changes] [WebKit/WebKit] 25d4c6: Do not update hasOutlineAutoAncestor when moving o...

JC Alvarado noreply at github.com
Fri Apr 28 06:51:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25d4c61111c5948d715b1d1b51ba086c274d1d61
      https://github.com/WebKit/WebKit/commit/25d4c61111c5948d715b1d1b51ba086c274d1d61
  Author: JC Alvarado <joncarlo at apple.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp

  Log Message:
  -----------
  Do not update hasOutlineAutoAncestor when moving out a spanner's renderer
https://bugs.webkit.org/show_bug.cgi?id=255956
rdar://107953410

Reviewed by Alan Baradlay.

When we move out a spanner's renderer, we might set the renderer as having
a hasOutlineAutoAncestor value of true and leave the spanner placeholder
with a hasOutlineAutoAncestor value of false. This is because when we move
out the spanner's renderer we set hasOutlineAutoAncestor based on its new
parent. However we want to maintain a value consistent with spanner's placholder.

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded const):
We want to check if the originalRenderer needs a repaint, not the placeholder.

* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::attachToRenderElementInternal):

Canonical link: https://commits.webkit.org/263501@main




More information about the webkit-changes mailing list