[webkit-changes] [WebKit/WebKit] ba2961: Animation control actions showing despite system a...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba29615655dc983216aaaace4b7161463e0cba99
      https://github.com/WebKit/WebKit/commit/ba29615655dc983216aaaace4b7161463e0cba99
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    A LayoutTests/fast/images/mac/animation-context-menu-items-presence-expected.txt
    A LayoutTests/fast/images/mac/animation-context-menu-items-presence.html
    M LayoutTests/fast/images/mac/play-all-pause-all-animations-context-menu-items.html
    M LayoutTests/fast/images/mac/play-pause-individual-animation-context-menu-items.html
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/page/ContextMenuController.cpp
    M Source/WebCore/page/Settings.yaml
    M Source/WebCore/testing/InternalSettings.cpp
    M Source/WebCore/testing/InternalSettings.h
    M Source/WebCore/testing/Internals.h

  Log Message:
  -----------
  Animation control actions showing despite system accessibility state
https://bugs.webkit.org/show_bug.cgi?id=256059
rdar://108583786

Reviewed by Chris Fleizach.

We should respect the system's preference for showing these controls in
ContextMenuController::populate.

* LayoutTests/fast/images/mac/animation-context-menu-items-presence-expected.txt: Added.
* LayoutTests/fast/images/mac/animation-context-menu-items-presence.html: Added.
* LayoutTests/fast/images/mac/play-all-pause-all-animations-context-menu-items.html:
* LayoutTests/fast/images/mac/play-pause-individual-animation-context-menu-items.html:
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
* Source/WebCore/page/Settings.yaml:
* Source/WebCore/testing/InternalSettings.cpp: Add AllowAnimationControlsOverride setting.
(WebCore::InternalSettings::setAllowAnimationControlsOverride): Added.
* Source/WebCore/testing/InternalSettings.h:
* Source/WebCore/testing/Internals.h:

Canonical link: https://commits.webkit.org/263481@main