[webkit-changes] [WebKit/WebKit] cfd110: [CoreIPC] Messages::GPUConnectionToWebProcess::Set...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cfd1105a34372cb245b99f959ab10c8bb2a1a48d
      https://github.com/WebKit/WebKit/commit/cfd1105a34372cb245b99f959ab10c8bb2a1a48d
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    M LayoutTests/http/tests/media/hls/hls-audio-tracks-locale-selection-expected.txt
    M LayoutTests/http/tests/media/hls/hls-audio-tracks-locale-selection.html
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in
    M Source/WebKit/GPUProcess/GPUProcess.cpp
    M Source/WebKit/GPUProcess/GPUProcess.h
    M Source/WebKit/GPUProcess/GPUProcess.messages.in
    M Source/WebKit/GPUProcess/GPUProcessCreationParameters.cpp
    M Source/WebKit/GPUProcess/GPUProcessCreationParameters.h
    M Source/WebKit/Shared/GPUProcessConnectionParameters.h
    M Source/WebKit/Shared/GPUProcessConnectionParameters.serialization.in
    M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp

  Log Message:
  -----------
  [CoreIPC] Messages::GPUConnectionToWebProcess::SetUserPreferredLanguages is sent from WCP and not UIP
https://bugs.webkit.org/show_bug.cgi?id=256014
<rdar://107917551>

Reviewed by Alex Christensen.

The UIProcess normally knows about language overrides and is thus able to IPC
them to the GPUProcess. This is to avoid having the untrusted WebProcesses
send the languages to the GPUProcess themselves.

Note that there is one exception: internals.setUserPreferredLanguages(). Since
this is called in the WebProcess, tests calling this will only override the
languages in the current WebProcess, not more globally (e.g. in the GPUProcess).

Tests that want/need to override the language more globally now have to use the
pre-existing `<!-- webkit-test-runner [ language=foo,bar ] -->` test option.

* LayoutTests/http/tests/media/hls/hls-audio-tracks-locale-selection-expected.txt:
* LayoutTests/http/tests/media/hls/hls-audio-tracks-locale-selection.html:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::m_routingArbitrator):
(WebKit::GPUConnectionToWebProcess::setUserPreferredLanguages): Deleted.
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in:
* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::initializeGPUProcess):
(WebKit::GPUProcess::userPreferredLanguagesChanged):
* Source/WebKit/GPUProcess/GPUProcess.h:
* Source/WebKit/GPUProcess/GPUProcess.messages.in:
* Source/WebKit/GPUProcess/GPUProcessCreationParameters.cpp:
(WebKit::GPUProcessCreationParameters::encode const):
(WebKit::GPUProcessCreationParameters::decode):
* Source/WebKit/GPUProcess/GPUProcessCreationParameters.h:
* Source/WebKit/Shared/GPUProcessConnectionParameters.h:
* Source/WebKit/Shared/GPUProcessConnectionParameters.serialization.in:
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::GPUProcessProxy):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setOverrideLanguages):
* Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::getGPUProcessConnectionParameters):
(WebKit::GPUProcessConnection::GPUProcessConnection):
(WebKit::GPUProcessConnection::~GPUProcessConnection):
(WebKit::languagesChanged): Deleted.

Canonical link: https://commits.webkit.org/263465@main