[webkit-changes] [WebKit/WebKit] f08108: [WPE] run-minibrowser: don't set a platform when C...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f081085077e66f9960c30e738f6b92fd896beb74
      https://github.com/WebKit/WebKit/commit/f081085077e66f9960c30e738f6b92fd896beb74
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    M Tools/PlatformWPE.cmake
    M Tools/Scripts/webkitpy/port/wpe.py
    M Tools/Scripts/webkitpy/port/wpe_unittest.py

  Log Message:
  -----------
  [WPE] run-minibrowser: don't set a platform when COG_PLATFORM_NAME is on the env
https://bugs.webkit.org/show_bug.cgi?id=256043

Reviewed by Philippe Normand.

Cog now can receive the platform plugin name via the environment variable COG_PLATFORM_NAME
This updates the version we checkout of Cog so it includes the above fix

The run-minibrowser script for WPE now checks for this environment variable before
passing any --platform parameters to Cog. Some extra tests are added also.

Also use logging module to log the errors on port/wpe.py to avoid having this errors getting
printed when running the python unit tests.

* Tools/PlatformWPE.cmake:
* Tools/Scripts/webkitpy/port/wpe.py:
(WPEPort.browser_name):
(WPEPort.run_minibrowser):
* Tools/Scripts/webkitpy/port/wpe_unittest.py:
(WPEPortTest._mock_port_cog_is_built):
(WPEPortTest.test_browser_name_default_wihout_cog_built):
(WPEPortTest.test_browser_name_default_with_cog_built):
(WPEPortTest.test_browser_name_override_minibrowser_with_cog_built):
(WPEPortTest.test_browser_name_override_unknown_without_cog_built):
(WPEPortTest):
(WPEPortTest.test_browser_name_override_unknown_with_cog_built):
(WPEPortTest.test_browser_cog_parameters_platform_default):
(WPEPortTest.test_browser_cog_parameters_platform_override_via_cmdline):
(WPEPortTest.test_browser_cog_parameters_platform_override_via_environ):
(WPEPortTest.test_browser_name_default): Deleted.
(WPEPortTest.test_browser_name_with_cog_built): Deleted.
(WPEPortTest.test_browser_name_override_unknown): Deleted.

Canonical link: https://commits.webkit.org/263463@main