[webkit-changes] [WebKit/WebKit] 8a95a4: [Cocoa] Extra transform left on video layer when U...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a95a469c00c748d915029c4d703f4cb8cfb82dc
      https://github.com/WebKit/WebKit/commit/8a95a469c00c748d915029c4d703f4cb8cfb82dc
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    M Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm

  Log Message:
  -----------
  [Cocoa] Extra transform left on video layer when UI-side compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=256027
rdar://108109357

Reviewed by Eric Carlson.

In -resolveBounds, we bail out early if the WKVideoLayerRemote has the correct bounds and has
a identity affineTransform. But in -layoutSublayers we apply the transform directly to the
videoLayer, rather than the WKVideoLayerRemote itself, so this check will always succeed.

Leaving the transformation in place _should_ have no perceivable side effects. However power
testing has revealed that in some circumstances, this layer change may result in excess power
use when displaying video in fullscreen mode.

* Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:
(-[WKVideoLayerRemote resolveBounds]):

Canonical link: https://commits.webkit.org/263456@main