[webkit-changes] [WebKit/WebKit] a277ac: [popover] Fix popover-move-documents.html

Rob Buis noreply at github.com
Thu Apr 27 01:30:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a277ac28923eb2251e9bbab43e6800c3205ca4dc
      https://github.com/WebKit/WebKit/commit/a277ac28923eb2251e9bbab43e6800c3205ca4dc
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-move-documents-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-move-documents.html
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  [popover] Fix popover-move-documents.html
https://bugs.webkit.org/show_bug.cgi?id=255780

Reviewed by Tim Nguyen.

The beforetoggle event handlers can move popover elements between documents, take this into account when
checking popover validity [1].

[1] https://github.com/whatwg/html/pull/9182

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-move-documents-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-move-documents.html: Added.
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::checkPopoverValidity):
(WebCore::HTMLElement::showPopover):
(WebCore::HTMLElement::hidePopoverInternal):

Canonical link: https://commits.webkit.org/263449@main




More information about the webkit-changes mailing list