[webkit-changes] [WebKit/WebKit] 67ce1e: [Shape Detection] Fix internal Apple build

Myles C. Maxfield noreply at github.com
Wed Apr 26 12:43:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67ce1e3fcec1df093c7f6e1f69f9126ede2bfc43
      https://github.com/WebKit/WebKit/commit/67ce1e3fcec1df093c7f6e1f69f9126ede2bfc43
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.h
    M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.mm
    M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.h
    M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.mm
    M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/TextDetectorImplementation.h
    M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/TextDetectorImplementation.mm
    M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.h
    M Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.mm
    M Source/WebCore/PAL/pal/cocoa/VisionSoftLink.h
    M Source/WebCore/PAL/pal/cocoa/VisionSoftLink.mm
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm

  Log Message:
  -----------
  [Shape Detection] Fix internal Apple build
https://bugs.webkit.org/show_bug.cgi?id=256001
rdar://108561521

Unreviewed build fix.

263397 at main broke the internal Apple build because it directly linked with Vision. Apparently,
Vision already depends on WebCore, so that patch created a cycle. This patch fixes it by using
soft linking instead.

* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.h:
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.mm:
(WebCore::ShapeDetection::convertSymbology):
(WebCore::ShapeDetection::convertBarcodeFormat):
(WebCore::ShapeDetection::request):
(WebCore::ShapeDetection::BarcodeDetectorImpl::detect):
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.h:
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.mm:
(WebCore::ShapeDetection::FaceDetectorImpl::detect):
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/TextDetectorImplementation.h:
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/TextDetectorImplementation.mm:
(WebCore::ShapeDetection::TextDetectorImpl::detect):
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.h:
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.mm:
* Source/WebCore/PAL/pal/cocoa/VisionSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/VisionSoftLink.mm:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:
(WebKit::requestPayloadForQRCode):

Canonical link: https://commits.webkit.org/263429@main




More information about the webkit-changes mailing list