[webkit-changes] [WebKit/WebKit] e5e7a5: AX: aria-flowto doesn't work for display:contents ...

Tyler Wilcock noreply at github.com
Wed Apr 26 12:23:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e5e7a5d1f961353ce7b71744987fe140fe6e5af0
      https://github.com/WebKit/WebKit/commit/e5e7a5d1f961353ce7b71744987fe140fe6e5af0
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    M LayoutTests/accessibility/aria-flowto-expected.txt
    M LayoutTests/accessibility/aria-flowto.html
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.h

  Log Message:
  -----------
  AX: aria-flowto doesn't work for display:contents elements
https://bugs.webkit.org/show_bug.cgi?id=255974
rdar://problem/108542797

Reviewed by Chris Fleizach.

Move the necessary implementations from AccessibilityRenderObject to
AcceAccessibilityNodeObject.

This patch also changes aria-flowto.html to wait after the dynamic JS
changes it does which allows it to start passing in ITM.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
* LayoutTests/accessibility/aria-flowto-expected.txt:
* LayoutTests/accessibility/aria-flowto.html:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::internalLinkElement const):
(WebCore::AccessibilityNodeObject::addRadioButtonGroupChildren const):
(WebCore::AccessibilityNodeObject::addRadioButtonGroupMembers const):
(WebCore::AccessibilityNodeObject::linkedObjects const):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::internalLinkElement const): Deleted.
(WebCore::AccessibilityRenderObject::addRadioButtonGroupChildren const): Deleted.
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers const): Deleted.
(WebCore::AccessibilityRenderObject::linkedObjects const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:

Canonical link: https://commits.webkit.org/263425@main




More information about the webkit-changes mailing list