[webkit-changes] [WebKit/WebKit] bf05a6: HTMLFormControlElement::popoverTargetElement() is ...

Arunsundar Kannan noreply at github.com
Wed Apr 26 09:23:43 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bf05a6ed90f856bf3a59b7ab4dd1dd7f14514aa8
      https://github.com/WebKit/WebKit/commit/bf05a6ed90f856bf3a59b7ab4dd1dd7f14514aa8
  Author: Arunsundar Kannan <arunsundar_kannan at apple.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M Source/WebCore/html/HTMLFormControlElement.cpp

  Log Message:
  -----------
  HTMLFormControlElement::popoverTargetElement() is broken when popover preference is disabled.
https://bugs.webkit.org/show_bug.cgi?id=255889.
rdar://108472734.

Reviewed by Tim Nguyen.

HTMLFormControlElement::popoverTargetElement() fails an assertion for availabity of pop over target attribute.This change checks if popoverAttribute is Enabled and bails if it is not enabled.

* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::popoverTargetElement const):

Canonical link: https://commits.webkit.org/263417@main




More information about the webkit-changes mailing list