[webkit-changes] [WebKit/WebKit] 0a9aa1: "Loading" spinner shown as Facebook videos play

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a9aa1413ba631faae8b1924493234638cffcc53
      https://github.com/WebKit/WebKit/commit/0a9aa1413ba631faae8b1924493234638cffcc53
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp

  Log Message:
  -----------
  "Loading" spinner shown as Facebook videos play
https://bugs.webkit.org/show_bug.cgi?id=255961
rdar://107842627

Reviewed by Jer Noble.

AVFoundation reports a maximum loaded time greater than the file's duration with some
Facebook videos. `MediaPlayerPrivateAVFoundation::updateStates` only changes the network
state from `NetworkState::Loading` to `NetworkState::Loaded` when the maximum time loaded
is _equal to_ the duration, which causes HTMLMediaElement to fire a `stalled` event.

* Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Set networkState to
`NetworkState::Loaded` when maximum time loaded is equal to or greater than duration.

Canonical link: https://commits.webkit.org/263413@main