[webkit-changes] [WebKit/WebKit] 50ae54: git-webkit: error when importing keyring module at...

Carlos Alberto Lopez Perez noreply at github.com
Wed Apr 26 04:20:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50ae54522fafa7296eedced4e2c1c83f8617b052
      https://github.com/WebKit/WebKit/commit/50ae54522fafa7296eedced4e2c1c83f8617b052
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/__init__.py

  Log Message:
  -----------
  git-webkit: error when importing keyring module at credentials.py
https://bugs.webkit.org/show_bug.cgi?id=255965

Reviewed by Michael Catanzaro and Jonathan Bedard.

The issue is currently only happening on Linux because we import a
newer version of the keyring module in the file
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py

When this module is imported it also imports importlib_metadata which
ends importing the module typing_extensions

So this will cause an error if the system doesn't has the python module
typing_extensions installed. Fix it by adding this module also to the
autoinstall list.

* Tools/Scripts/webkitpy/__init__.py:

Canonical link: https://commits.webkit.org/263410@main




More information about the webkit-changes mailing list