[webkit-changes] [WebKit/WebKit] 05aaf4: Remove LegacyDownloadClient code for SystemPreview

Dean Jackson noreply at github.com
Tue Apr 25 16:25:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05aaf4a5692421321939630ecd0612308082ed21
      https://github.com/WebKit/WebKit/commit/05aaf4a5692421321939630ecd0612308082ed21
  Author: Dean Jackson <dino at apple.com>
  Date:   2023-04-25 (Tue, 25 Apr 2023)

  Changed paths:
    M Source/WebCore/html/HTMLAnchorElement.cpp
    M Source/WebCore/loader/FrameLoadRequest.cpp
    M Source/WebCore/loader/FrameLoadRequest.h
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/FrameLoader.h
    M Source/WebCore/loader/FrameLoaderTypes.h
    M Source/WebCore/platform/network/ResourceRequestBase.cpp
    M Source/WebCore/platform/network/ResourceRequestBase.h
    M Source/WebCore/platform/network/cf/ResourceRequest.h
    M Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/API/APINavigation.h
    M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.h
    M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Remove LegacyDownloadClient code for SystemPreview
https://bugs.webkit.org/show_bug.cgi?id=255957
rdar://108526852

Reviewed by Tim Horton.

https://bugs.webkit.org/show_bug.cgi?id=255954 implements a new way to trigger
this code, so the old way can be deleted. This will make Alex happy.

* Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
* Source/WebCore/loader/FrameLoadRequest.cpp:
(WebCore::FrameLoadRequest::FrameLoadRequest):
* Source/WebCore/loader/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::isSystemPreview const): Deleted.
(WebCore::FrameLoadRequest::systemPreviewInfo const): Deleted.
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::loadURL):
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/loader/FrameLoaderTypes.h:
* Source/WebCore/platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::isSystemPreview const): Deleted.
(WebCore::ResourceRequestBase::systemPreviewInfo const): Deleted.
(WebCore::ResourceRequestBase::setSystemPreviewInfo): Deleted.
* Source/WebCore/platform/network/ResourceRequestBase.h:
* Source/WebCore/platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
* Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::fromResourceRequestData):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/API/APINavigation.h:
(API::Navigation::isSystemPreview const): Deleted.
* Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.h:
* Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm:
(WebKit::LegacyDownloadClient::legacyDidStart):
(WebKit::LegacyDownloadClient::didReceiveResponse):
(WebKit::LegacyDownloadClient::didReceiveData):
(WebKit::LegacyDownloadClient::didCreateDestination):
(WebKit::LegacyDownloadClient::processDidCrash):
(WebKit::LegacyDownloadClient::decideDestinationWithSuggestedFilename):
(WebKit::LegacyDownloadClient::didFinish):
(WebKit::LegacyDownloadClient::didFail):
(WebKit::LegacyDownloadClient::legacyDidCancel):
(WebKit::systemPreviewController): Deleted.
(WebKit::LegacyDownloadClient::takeActivityToken): Deleted.
(WebKit::LegacyDownloadClient::releaseActivityTokenIfNecessary): Deleted.
* Source/WebKit/UIProcess/Downloads/DownloadProxy.h:
(WebKit::DownloadProxy::isSystemPreviewDownload const): Deleted.
(WebKit::DownloadProxy::systemPreviewDownloadInfo const): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):

Canonical link: https://commits.webkit.org/263392@main




More information about the webkit-changes mailing list