[webkit-changes] [WebKit/WebKit] d573b8: [ews] Expected additionalArguments frequently miss...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d573b83aa2c218b96c855021965c9a683f231274
      https://github.com/WebKit/WebKit/commit/d573b83aa2c218b96c855021965c9a683f231274
  Author: Aakash Jain <aakash_jain at apple.com>
  Date:   2023-04-25 (Tue, 25 Apr 2023)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py

  Log Message:
  -----------
  [ews] Expected additionalArguments frequently missing from iOS layout test queues
https://bugs.webkit.org/show_bug.cgi?id=255742

Reviewed by Ryan Haddad.

additionalArguments were missing because in CompileWebKit class (and sub-classes), we were inadvertently removing
them. Especially compile-webkit-without-change step was the one removing the additionalArguments. This accessed build property
and removed various values from it, buy since a list is accessed by reference, original property was also modified.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit): Do not explicitly remove arguments, instead just check if the additionalArguments is within valid list for that step.
(RunWebKitTests): Drive-by fix. Code refactoring to adopt clener approach to handle additionalArguments, using ENABLE_ADDITIONAL_ARGUMENTS.
(RunWebKitTestsInStressMode): Ditto.
(RunWebKitTestsInStressMode.setLayoutTestCommand): Ditto.
(Trigger.propertiesToPassToTriggers): Revert previous attempt to fix this issue.

Canonical link: https://commits.webkit.org/263387@main