[webkit-changes] [WebKit/WebKit] 0f7e57: [WTR] Watchdog timer should not default to zero se...

[Alicia Boya García]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f7e57b5ef162bacc8d7e0444735262f122a68ec
      https://github.com/WebKit/WebKit/commit/0f7e57b5ef162bacc8d7e0444735262f122a68ec
  Author: Alicia Boya Garcia <aboya at igalia.com>
  Date:   2023-04-25 (Tue, 25 Apr 2023)

  Changed paths:
    M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  -----------
  [WTR] Watchdog timer should not default to zero seconds
https://bugs.webkit.org/show_bug.cgi?id=255920

Reviewed by Carlos Garcia Campos.

TestInvocation::m_timeout can have two special values: zero, for a
default timeout, and -1 for no timeout.

The current implementation of
initializeWaitToDumpWatchdogTimerIfNeeded() was not taking this into
consideration, which caused tests to immediately timeout (0 second
timeout) when invoking WebKitTestRunner without --no-timeout.

* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):

Canonical link: https://commits.webkit.org/263374@main