[webkit-changes] [WebKit/WebKit] 984732: [GTK] Remove TEST_RUNNER_TEST_PLUGIN_PATH

[Alicia Boya García]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 984732ae28a9ad9a2d55c026bd665326f035e59d
      https://github.com/WebKit/WebKit/commit/984732ae28a9ad9a2d55c026bd665326f035e59d
  Author: Alicia Boya Garcia <aboya at igalia.com>
  Date:   2023-04-25 (Tue, 25 Apr 2023)

  Changed paths:
    M Tools/Scripts/run-jsc-benchmarks
    M Tools/Scripts/webkitdirs.pm
    M Tools/Scripts/webkitpy/port/glib.py
    M Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp

  Log Message:
  -----------
  [GTK] Remove TEST_RUNNER_TEST_PLUGIN_PATH
https://bugs.webkit.org/show_bug.cgi?id=254814

Reviewed by Carlos Garcia Campos.

This patch removes the remaining references to
TEST_RUNNER_TEST_PLUGIN_PATH in the GTK test runner.

As support for plugins has long been removed from WebKit, no plugins
were compiled already, but because of these lingering references
WebKitTestRunner still refused to run in GTK without that variable set,
even though it's value was unused.

By fixing that, this patch makes it more intuitive to run the
WebKitTestRunner independently of the full blown LayoutTestRunner.

For instance, if you want to see the visual output of a page using the
testing internals API used by LayoutTests, you can run:

    WebKitTestRunner --no-timeout --show-window <URL>

Before this worked only if a TEST_RUNNER_TEST_PLUGIN_PATH environment
variable was passed with a dummy value.

* Tools/Scripts/run-jsc-benchmarks:
* Tools/Scripts/webkitdirs.pm:
(setupUnixWebKitEnvironment):
* Tools/Scripts/webkitpy/port/glib.py:
(GLibPort.setup_environ_for_server):
* Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::initializeTestPluginDirectory):

Canonical link: https://commits.webkit.org/263369@main