[webkit-changes] [WebKit/WebKit] 4472b6: Add a circular bit to modern media controls' Button

Tim Horton noreply at github.com
Tue Apr 25 02:24:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4472b61acbea6174657bf7df150f2606c492c54f
      https://github.com/WebKit/WebKit/commit/4472b61acbea6174657bf7df150f2606c492c54f
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2023-04-25 (Tue, 25 Apr 2023)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/button.css
    M Source/WebCore/Modules/modern-media-controls/controls/button.js
    M Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.css

  Log Message:
  -----------
  Add a circular bit to modern media controls' Button
https://bugs.webkit.org/show_bug.cgi?id=255904
rdar://108487065

Reviewed by Dean Jackson.

* Source/WebCore/Modules/modern-media-controls/controls/button.css:
(button.circular):
* Source/WebCore/Modules/modern-media-controls/controls/button.js:
(Button.prototype.get circular):
(Button.prototype.set circular):
(Button.prototype._updateImageMetrics):
(Button):
* Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.css:
(.media-controls.inline > .controls-bar button:not(.circular)):
(.media-controls.inline > .controls-bar button): Deleted.
Add a bit, orthogonal to the style (because we want to use it both with Bar and Rounded buttons),
indicating that a button should be fully circular, and adjust the metrics accordingly.

Canonical link: https://commits.webkit.org/263356@main




More information about the webkit-changes mailing list