[webkit-changes] [WebKit/WebKit] 2ae8e5: Add isTabOrSpace to WTF
Anne van Kesteren
noreply at github.com
Tue Apr 25 01:09:04 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2ae8e53cdb4a77a7b7ebf9c8a790fbe8099f60eb
https://github.com/WebKit/WebKit/commit/2ae8e53cdb4a77a7b7ebf9c8a790fbe8099f60eb
Author: Anne van Kesteren <annevk at annevk.nl>
Date: 2023-04-25 (Tue, 25 Apr 2023)
Changed paths:
M Source/WTF/wtf/ASCIICType.h
M Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp
M Source/WebCore/html/track/VTTCue.cpp
M Source/WebCore/html/track/VTTRegion.cpp
M Source/WebCore/html/track/WebVTTParser.cpp
M Source/WebCore/html/track/WebVTTParser.h
M Source/WebCore/loader/HTTPHeaderField.cpp
M Source/WebCore/loader/HeaderFieldTokenizer.cpp
M Source/WebCore/loader/LinkHeader.cpp
M Source/WebCore/platform/network/HTTPParsers.cpp
M Source/WebCore/platform/network/RFC7230.cpp
M Source/WebCore/platform/network/RFC7230.h
M Source/WebCore/platform/network/RFC8941.cpp
Log Message:
-----------
Add isTabOrSpace to WTF
https://bugs.webkit.org/show_bug.cgi?id=255842
rdar://108426795
Reviewed by Darin Adler.
Consolidates a number of separate initiatives at defining (and inlining) tab '\t' or space ' '.
* Source/WTF/wtf/ASCIICType.h:
(WTF::isASCIITabOrSpace):
* Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::parseParameters):
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::setCueSettings):
* Source/WebCore/html/track/VTTRegion.cpp:
(WebCore::VTTRegion::setRegionSettings):
* Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::checkAndCreateRegion):
(WebCore::WebVTTParser::checkStyleSheet):
The comment here talks about tab or space, but this preserves the existing functionality for now,
modulo using isASCIIWhitespace instead of something locally defined. This might be worth following
up on.
* Source/WebCore/html/track/WebVTTParser.h:
* Source/WebCore/loader/HTTPHeaderField.cpp:
(WebCore::HTTPHeaderField::create):
* Source/WebCore/loader/HeaderFieldTokenizer.cpp:
(WebCore::HeaderFieldTokenizer::consume):
(WebCore::HeaderFieldTokenizer::skipSpaces):
* Source/WebCore/loader/LinkHeader.cpp:
(WebCore::isParameterValueChar):
(WebCore::findURLBoundaries):
(WebCore::parseParameterDelimiter):
(WebCore::parseParameterName):
(WebCore::parseParameterValue):
(WebCore::isSpaceOrTab): Deleted.
* Source/WebCore/platform/network/HTTPParsers.cpp:
(WebCore::skipWhiteSpace):
(WebCore::skipValue):
(WebCore::isValidHTTPHeaderValue):
(WebCore::extractMIMETypeFromMediaType):
(WebCore::parseRange):
(WebCore::isTabOrSpace): Deleted.
* Source/WebCore/platform/network/RFC7230.cpp:
(RFC7230::isQuotedTextCharacter):
(RFC7230::isQuotedPairSecondOctet):
(RFC7230::isCommentText):
(RFC7230::isValidValue):
* Source/WebCore/platform/network/RFC7230.h:
(RFC7230::isWhitespace): Deleted.
* Source/WebCore/platform/network/RFC8941.cpp:
(RFC8941::parseDictionary):
Canonical link: https://commits.webkit.org/263354@main
More information about the webkit-changes
mailing list