[webkit-changes] [WebKit/WebKit] a92117: CSS hypot() function sometimes returns the result ...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a9211716efb3a877fe390339ffccfd369c3bda46
      https://github.com/WebKit/WebKit/commit/a9211716efb3a877fe390339ffccfd369c3bda46
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt
    M Source/WebCore/platform/calc/CalcExpressionOperation.cpp

  Log Message:
  -----------
  CSS hypot() function sometimes returns the result squared
https://bugs.webkit.org/show_bug.cgi?id=255905
rdar://108487071

Reviewed by Tim Horton.

In cases where the result is computed by CalcExpressionOperation.cpp, the result ends up being squared, because we're missing a sqrt() operation.
The result is correct for cases computed by CSSCalcOperationNode.cpp however, ideally code should be shared to prevent these types of bugs.

* LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt:
* Source/WebCore/platform/calc/CalcExpressionOperation.cpp:
(WebCore::CalcExpressionOperation::evaluate const):

Canonical link: https://commits.webkit.org/263351@main