[webkit-changes] [WebKit/WebKit] afb133: [CURL][SOUP] Extract common data URL logic into sh...

Yury Semikhatsky noreply at github.com
Mon Apr 24 18:49:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: afb1339d37f44414e98767bb0bc75cb0ab71c139
      https://github.com/WebKit/WebKit/commit/afb1339d37f44414e98767bb0bc75cb0ab71c139
  Author: Yury Semikhatsky <yurys at chromium.org>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkDataTask.cpp
    A Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.cpp
    A Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.h
    M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
    M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.h
    M Source/WebKit/SourcesGTK.txt
    M Source/WebKit/SourcesWPE.txt

  Log Message:
  -----------
  [CURL][SOUP] Extract common data URL logic into shared NetworkDataTaskDataURL
https://bugs.webkit.org/show_bug.cgi?id=255750

Reviewed by Fujii Hironori.

Curl and Soup don't support data: URLs and the download logic for both
of these platforms is mostly the same. This change extracts common bits
of data urls handling into NetworkDataTaskDataURL which can be shared
by both platforms.

* Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.cpp: Added.
(WebKit::NetworkDataTaskDataURL::create):
(WebKit::NetworkDataTaskDataURL::NetworkDataTaskDataURL):
(WebKit::NetworkDataTaskDataURL::~NetworkDataTaskDataURL):
(WebKit::NetworkDataTaskDataURL::resume): note that this task never gets back
to the suspended state once it has been initially resumed.
(WebKit::NetworkDataTaskDataURL::cancel):
(WebKit::NetworkDataTaskDataURL::invalidateAndCancel):
(WebKit::NetworkDataTaskDataURL::state const):
(WebKit::NetworkDataTaskDataURL::setPendingDownloadLocation):
(WebKit::NetworkDataTaskDataURL::suggestedFilename const):
(WebKit::NetworkDataTaskDataURL::didDecodeDataURL):
(WebKit::NetworkDataTaskDataURL::downloadDecodedData):
* Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.h: Added.
* Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::create):
(WebKit::NetworkDataTaskSoup::createRequest):
(WebKit::NetworkDataTaskSoup::clearRequest):
(WebKit::NetworkDataTaskSoup::resume):
(WebKit::NetworkDataTaskSoup::didReadDataURL): Deleted.
* Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.h:
* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/SourcesWPE.txt:

Canonical link: https://commits.webkit.org/263349@main




More information about the webkit-changes mailing list