[webkit-changes] [WebKit/WebKit] 9358d2: UI-Side Compositing : Text on a Button in PDF and ...

Richard Robinson noreply at github.com
Mon Apr 24 15:45:52 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9358d2aa116959580bc484002179a2cc3e133698
      https://github.com/WebKit/WebKit/commit/9358d2aa116959580bc484002179a2cc3e133698
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm

  Log Message:
  -----------
  UI-Side Compositing : Text on a Button in PDF and inputted text appear upside down
https://bugs.webkit.org/show_bug.cgi?id=255797
rdar://107127603

Reviewed by Megan Gardner.

With UI-side compositing, PDF annotations were rendered upside-down due to `isGeometryFlipped`
being `true` for their layers.

This PR fixes this by adopting a PDFKit delegate method on the PDF layer controller's delegate
to access each annotation's layers, and then flips them vertically with a transform to get them
to be the correct orientation.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate initWithPDFPlugin:]):
(-[WKPDFLayerControllerDelegate pdfLayerController:didUpdateLayer:forAnnotation:]):
(WebKit::PDFPlugin::setView):

Canonical link: https://commits.webkit.org/263343@main




More information about the webkit-changes mailing list