[webkit-changes] [WebKit/WebKit] 35779e: Attachment (wide-layout): Use semantic color for t...

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35779e4c19aee3f6468b45c518530166a599159e
      https://github.com/WebKit/WebKit/commit/35779e4c19aee3f6468b45c518530166a599159e
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/parser/CSSParserIdioms.cpp
    M Source/WebCore/html/shadow/attachmentElementShadow.css
    M Source/WebCore/rendering/RenderThemeIOS.mm

  Log Message:
  -----------
  Attachment (wide-layout): Use semantic color for the save icon background on iOS
https://bugs.webkit.org/show_bug.cgi?id=255849
rdar://107157550

Reviewed by Aditya Keerthi.

Without a proper semantic color, the color doesn't get updated when switching between light and dark modes.
The "-apple-system-opaque-tertiary-fill" color is not semantic, instead "-apple-system-tertiary-fill" should be used (as was already done on macOS).

* LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSParserIdioms.cpp:
(WebCore::isValueAllowedInMode):
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(button#attachment-save-button):
* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::cssValueSystemColorInformationList):

Canonical link: https://commits.webkit.org/263340@main