[webkit-changes] [WebKit/WebKit] 830871: [JSC] Some simd operations in BBQ have the wrong size

Tadeu Zagallo noreply at github.com
Mon Apr 24 13:11:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8308719e1589f96792eba25315d7939e97f67044
      https://github.com/WebKit/WebKit/commit/8308719e1589f96792eba25315d7939e97f67044
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    A JSTests/wasm/stress/simd-no-fast-mem-load-lane.js
    A JSTests/wasm/stress/simd-no-fast-mem-load-splat.js
    A JSTests/wasm/stress/simd-no-fast-mem-store-lane.js
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  -----------
  [JSC] Some simd operations in BBQ have the wrong size
https://bugs.webkit.org/show_bug.cgi?id=255859
rdar://108148560

Reviewed by Yusuke Suzuki.

Three operations in BBQ (loadN_splat, loadN_lane and storeN_lane) were always
using Width128, but their size actually depend on the opcode.

* JSTests/wasm/stress/simd-no-fast-mem-load-lane.js: Added.
(from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.memory.1.data.i32.const.0.string_appeared_here.data.i32.const.65520.string_appeared_here.func.export.string_appeared_here.result.i32.i8x16.extract_lane_s.0.v128.load8_lane.0.i32.const.65535.v128.const.i8x16.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.async test):
* JSTests/wasm/stress/simd-no-fast-mem-load-splat.js: Added.
(from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.memory.1.data.i32.const.0.string_appeared_here.data.i32.const.65520.string_appeared_here.func.export.string_appeared_here.result.i32.i8x16.extract_lane_s.0.v128.load8_splat.i32.const.65535.async test):
* JSTests/wasm/stress/simd-no-fast-mem-store-lane.js: Added.
(from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.memory.1.data.i32.const.0.string_appeared_here.data.i32.const.65520.string_appeared_here.func.export.string_appeared_here.result.i32.v128.store8_lane.0.i32.const.65535.v128.const.i8x16.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.i32.load8_u.i32.const.65535.async test):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::addSIMDLoadSplat):
(JSC::Wasm::BBQJIT::addSIMDLoadLane):
(JSC::Wasm::BBQJIT::addSIMDStoreLane):

Canonical link: https://commits.webkit.org/263329@main




More information about the webkit-changes mailing list