[webkit-changes] [WebKit/WebKit] 584a13: [Cocoa] Videos on store.steampowered.com play as b...

Jer Noble noreply at github.com
Mon Apr 24 12:33:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 584a1356823c7fa6be4d13ea0e927f7845e8c844
      https://github.com/WebKit/WebKit/commit/584a1356823c7fa6be4d13ea0e927f7845e8c844
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm

  Log Message:
  -----------
  [Cocoa] Videos on store.steampowered.com play as black window with audio the first time full screened
https://bugs.webkit.org/show_bug.cgi?id=255875
rdar://108291733

Reviewed by Eric Carlson.

When the compositing code asks for a layer to be created for a video element, it may already be
displaying video content in fullscreen or a picture-in-picture window. In this case, the newly
created video layer shouldn't try to reparent the video content out of fullscreen/pip and into
the inline layer.

* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::createLayerWithID):
(WebKit::VideoFullscreenManagerProxy::createViewWithID):

Canonical link: https://commits.webkit.org/263327@main




More information about the webkit-changes mailing list