[webkit-changes] [WebKit/WebKit] f1b46a: [css-tables] Percentage sizing of table cell repla...

Ahmad Saleem noreply at github.com
Mon Apr 24 10:15:24 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1b46a85d1832015e14aae60079bed2e9db93f02
      https://github.com/WebKit/WebKit/commit/f1b46a85d1832015e14aae60079bed2e9db93f02
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/height-distribution/support/scrollbars.css
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  [css-tables] Percentage sizing of table cell replaced children with scrollbar

https://bugs.webkit.org/show_bug.cgi?id=255854

Reviewed by Simon Fraser.

This patch aligns Webkit with Blink / Chromium.

Merge: https://chromium.googlesource.com/chromium/src.git/+/bf802aa687ff50a9f4017376cf92da49915f6f8b

When computing the percentage height of table cell replaced children,
if the table cell has horizontal scrollbar we have to subtract
its height from the overridingLogicalHeight().

* Source/WebCore/rendering/RenderBox.cpp:
(RenderBox::availableLogicalHeightUsing): As per commit message
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/height-distribution/support/scrollbars.css: Support file
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html: Add Test
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001-ref.html: Add WPT Reference File
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001-expected.html: Add Test Case Expectation

Canonical link: https://commits.webkit.org/263318@main




More information about the webkit-changes mailing list