[webkit-changes] [WebKit/WebKit] d20f97: [GStreamer][Debug] mediarecorder tests hitting ASSERT

Philippe Normand noreply at github.com
Mon Apr 24 03:29:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d20f97b6f4a007545c03747e15b4728eff8984e6
      https://github.com/WebKit/WebKit/commit/d20f97b6f4a007545c03747e15b4728eff8984e6
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  -----------
  [GStreamer][Debug] mediarecorder tests hitting ASSERT
https://bugs.webkit.org/show_bug.cgi?id=255786

Reviewed by Xabier Rodriguez-Calvar.

The MediaStream GStreamer source element now stops observation of its InternalSources from the
dispose function, in order to avoid potentially unsafe behaviours when the element is used from a
non-main thread, such as the one created by GstTranscoder.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcDispose):
(webkitMediaStreamSrcChangeState):

Canonical link: https://commits.webkit.org/263305@main




More information about the webkit-changes mailing list