[webkit-changes] [WebKit/WebKit] b5a91e: [JSC] Implement ctiMasmProbeTrampolineSIMD for MSVC

Ross Kirsling noreply at github.com
Mon Apr 24 02:40:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b5a91e8e40a684cd9fe7694da3ba16b75a2470a9
      https://github.com/WebKit/WebKit/commit/b5a91e8e40a684cd9fe7694da3ba16b75a2470a9
  Author: Ross Kirsling <rkirsling at gmail.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp
    M Source/JavaScriptCore/jit/JITStubsMSVC64.asm

  Log Message:
  -----------
  [JSC] Implement ctiMasmProbeTrampolineSIMD for MSVC
https://bugs.webkit.org/show_bug.cgi?id=255856

Reviewed by Yusuke Suzuki.

258282 at main implemented ctiMasmProbeTrampolineSIMD for non-MSVC x86_64, this patch implements the MSVC version.
(As with non-MSVC, this is identical to ctiMasmProbeTrampoline except for the use of vmovaps.)

Without this, testProbeModifiesStackPointerToInsideProbeStateOnStack fails in testmasm.
(The size of Probe::State increased with the addition of fprs.vectors, but the position on the stack did not change,
meaning that the last iteration(s) would try to move the stack pointer in a *positive* direction.)

* Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp:
(JSC::MacroAssembler::probe):
* Source/JavaScriptCore/jit/JITStubsMSVC64.asm:

Canonical link: https://commits.webkit.org/263301@main




More information about the webkit-changes mailing list