[webkit-changes] [WebKit/WebKit] 29adb2: Full screen message shifts up when controls disapp...

Jean-Yves Avenard noreply at github.com
Sun Apr 23 20:27:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29adb2b287fb17f11ff8f085c40b543b90166907
      https://github.com/WebKit/WebKit/commit/29adb2b287fb17f11ff8f085c40b543b90166907
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-04-23 (Sun, 23 Apr 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

  Log Message:
  -----------
  Full screen message shifts up when controls disappear, just before it also disappears
https://bugs.webkit.org/show_bug.cgi?id=255777
rdar://106225913

Reviewed by Jer Noble.

We had two animations happening in parallel: hiding the banner and hiding
the UI controls.
Both were set to happen for the same duration but in effect this wasn't
the case.
When the UI controls got hidden, the status bar was set to disappeared
which changed the logical location of the full screen banner and gave the
impression it was shifting up.

Change the anchors of the fullscreen banner to use the one of the parent
view instead.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController loadView]):

Canonical link: https://commits.webkit.org/263295@main




More information about the webkit-changes mailing list