[webkit-changes] [WebKit/WebKit] 20416c: [Quirks mode only] "Do not trim trailing whitespac...

Alan Baradlay noreply at github.com
Sun Apr 23 10:49:03 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20416c8f90abc45c34a3ac1abd0c1a354a68a879
      https://github.com/WebKit/WebKit/commit/20416c8f90abc45c34a3ac1abd0c1a354a68a879
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-04-23 (Sun, 23 Apr 2023)

  Changed paths:
    M LayoutTests/accessibility/mac/table-relative-frame-expected.txt
    M LayoutTests/editing/execCommand/format-block-from-range-selection-expected.txt
    M LayoutTests/editing/execCommand/insert-image-in-composed-list-expected.txt
    M LayoutTests/editing/execCommand/remove-list-items-expected.txt
    M LayoutTests/editing/execCommand/switch-list-type-expected.txt
    M LayoutTests/editing/pasteboard/copy-paste-converts-fixed-expected.txt
    M LayoutTests/editing/pasteboard/copy-paste-converts-sticky-expected.txt
    M LayoutTests/editing/pasteboard/copy-paste-wraps-position-absolute-expected.txt
    M LayoutTests/editing/pasteboard/paste-after-inline-style-element-expected.txt
    M LayoutTests/editing/pasteboard/paste-noscript-expected.txt
    M LayoutTests/imported/blink/editing/selection/unrooted-selection-start-crash-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/editing/other/insert-text-in-void-element.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/the-innertext-and-outertext-properties/getter-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/innerText/getter-expected.txt
    M LayoutTests/platform/ios-wk2/fast/forms/textarea-align-expected.txt
    M LayoutTests/platform/ios-wk2/fast/replaced/border-radius-clip-expected.txt
    M LayoutTests/platform/ios/css1/box_properties/float_on_text_elements-expected.txt
    M LayoutTests/platform/ios/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt
    M LayoutTests/platform/ios/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt
    M LayoutTests/platform/ios/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt
    M LayoutTests/platform/ios/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt
    M LayoutTests/platform/ios/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt
    M LayoutTests/platform/ios/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt
    M LayoutTests/platform/ios/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt
    M LayoutTests/platform/ios/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt
    M LayoutTests/platform/ios/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt
    M LayoutTests/platform/ios/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt
    M LayoutTests/platform/ios/editing/deleting/non-smart-delete-expected.txt
    M LayoutTests/platform/ios/editing/execCommand/5142012-2-expected.txt
    M LayoutTests/platform/ios/editing/inserting/insert-br-quoted-001-expected.txt
    M LayoutTests/platform/ios/editing/inserting/insert-br-quoted-002-expected.txt
    M LayoutTests/platform/ios/editing/inserting/insert-br-quoted-003-expected.txt
    M LayoutTests/platform/ios/editing/inserting/insert-br-quoted-004-expected.txt
    M LayoutTests/platform/ios/editing/inserting/insert-br-quoted-005-expected.txt
    M LayoutTests/platform/ios/editing/inserting/insert-br-quoted-006-expected.txt
    M LayoutTests/platform/ios/editing/inserting/insert-div-026-expected.txt
    M LayoutTests/platform/ios/editing/inserting/return-key-with-selection-001-expected.txt
    M LayoutTests/platform/ios/editing/inserting/return-key-with-selection-002-expected.txt
    M LayoutTests/platform/ios/editing/inserting/return-key-with-selection-003-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-4038267-fix-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-line-endings-001-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-line-endings-002-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-line-endings-003-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-line-endings-004-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-line-endings-005-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-line-endings-006-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-line-endings-007-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-line-endings-008-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-line-endings-009-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-line-endings-010-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-match-style-001-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-match-style-002-expected.txt
    M LayoutTests/platform/ios/editing/pasteboard/paste-text-019-expected.txt
    M LayoutTests/platform/ios/editing/style/block-styles-007-expected.txt
    M LayoutTests/platform/ios/editing/style/create-block-for-style-013-expected.txt
    M LayoutTests/platform/ios/editing/style/style-3998892-fix-expected.txt
    M LayoutTests/platform/ios/editing/style/style-boundary-004-expected.txt
    M LayoutTests/platform/ios/editing/unsupported-content/list-delete-003-expected.txt
    M LayoutTests/platform/ios/editing/unsupported-content/list-type-after-expected.txt
    M LayoutTests/platform/ios/fast/css-generated-content/table-row-group-to-inline-expected.txt
    M LayoutTests/platform/ios/fast/css-generated-content/table-row-group-with-before-expected.txt
    M LayoutTests/platform/ios/fast/css-generated-content/table-row-with-before-expected.txt
    M LayoutTests/platform/ios/fast/css-generated-content/table-with-before-expected.txt
    M LayoutTests/platform/ios/fast/css/font-smoothing-expected.txt
    M LayoutTests/platform/ios/fast/css/outline-narrowLine-expected.txt
    M LayoutTests/platform/ios/fast/css/rtl-ordering-expected.txt
    M LayoutTests/platform/ios/fast/css/text-overflow-input-expected.txt
    M LayoutTests/platform/ios/fast/css/text-rendering-expected.txt
    M LayoutTests/platform/ios/fast/css/word-space-extra-expected.txt
    M LayoutTests/platform/ios/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt
    M LayoutTests/platform/ios/fast/dynamic/selection-highlight-adjust-expected.txt
    M LayoutTests/platform/ios/fast/forms/input-appearance-height-expected.txt
    M LayoutTests/platform/ios/fast/forms/plaintext-mode-2-expected.txt
    M LayoutTests/platform/ios/fast/forms/select-initial-position-expected.txt
    M LayoutTests/platform/ios/fast/forms/select-style-expected.txt
    M LayoutTests/platform/ios/fast/forms/select/optgroup-rendering-expected.txt
    M LayoutTests/platform/ios/fast/forms/textarea-align-expected.txt
    M LayoutTests/platform/ios/fast/forms/textarea-scrolled-type-expected.txt
    M LayoutTests/platform/ios/fast/images/image-map-anchor-children-expected.txt
    M LayoutTests/platform/ios/fast/inline/positionedLifetime-expected.txt
    M LayoutTests/platform/ios/fast/layers/layer-visibility-sublayer-expected.txt
    M LayoutTests/platform/ios/fast/replaced/border-radius-clip-expected.txt
    M LayoutTests/platform/ios/fast/text/basic/012-expected.txt
    M LayoutTests/platform/ios/fast/text/international/bidi-LDB-2-CSS-expected.txt
    M LayoutTests/platform/ios/fast/text/international/bidi-LDB-2-HTML-expected.txt
    M LayoutTests/platform/ios/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt
    M LayoutTests/platform/ios/fast/writing-mode/basic-vertical-line-expected.txt
    M LayoutTests/platform/ios/fast/writing-mode/basic-vertical-line-mixed-expected.txt
    M LayoutTests/platform/ios/fast/writing-mode/border-vertical-lr-expected.txt
    M LayoutTests/platform/ios/fast/writing-mode/english-lr-text-expected.txt
    M LayoutTests/platform/ios/fast/writing-mode/fieldsets-expected.txt
    M LayoutTests/platform/ios/fonts/monospace-expected.txt
    M LayoutTests/platform/ios/fonts/sans-serif-expected.txt
    M LayoutTests/platform/ios/fonts/serif-expected.txt
    M LayoutTests/platform/ios/http/tests/local/file-url-sent-as-referer-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/bugs/bug113235-1-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/bugs/bug28928-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/bugs/bug6404-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/core/bloomberg-expected.txt
    M LayoutTests/platform/ios/transforms/3d/general/perspective-units-expected.txt
    M LayoutTests/platform/ios/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt
    M LayoutTests/platform/mac-wk2/fast/layers/layer-visibility-sublayer-expected.txt
    M LayoutTests/platform/mac/css1/box_properties/float_on_text_elements-expected.txt
    M LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt
    M LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt
    M LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt
    M LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt
    M LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt
    M LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt
    M LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt
    M LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt
    M LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt
    M LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt
    M LayoutTests/platform/mac/editing/deleting/non-smart-delete-expected.txt
    M LayoutTests/platform/mac/editing/execCommand/5142012-2-expected.txt
    M LayoutTests/platform/mac/editing/inserting/insert-br-quoted-001-expected.txt
    M LayoutTests/platform/mac/editing/inserting/insert-br-quoted-002-expected.txt
    M LayoutTests/platform/mac/editing/inserting/insert-br-quoted-003-expected.txt
    M LayoutTests/platform/mac/editing/inserting/insert-br-quoted-004-expected.txt
    M LayoutTests/platform/mac/editing/inserting/insert-br-quoted-005-expected.txt
    M LayoutTests/platform/mac/editing/inserting/insert-br-quoted-006-expected.txt
    M LayoutTests/platform/mac/editing/inserting/insert-div-026-expected.txt
    M LayoutTests/platform/mac/editing/inserting/return-key-with-selection-001-expected.txt
    M LayoutTests/platform/mac/editing/inserting/return-key-with-selection-002-expected.txt
    M LayoutTests/platform/mac/editing/inserting/return-key-with-selection-003-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/emacs-cntl-y-001-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-4038267-fix-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-line-endings-001-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-line-endings-002-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-line-endings-003-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-line-endings-004-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-line-endings-005-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-line-endings-006-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-line-endings-007-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-line-endings-008-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-line-endings-009-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-line-endings-010-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-match-style-001-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-match-style-002-expected.txt
    M LayoutTests/platform/mac/editing/pasteboard/paste-text-019-expected.txt
    M LayoutTests/platform/mac/editing/style/block-styles-007-expected.txt
    M LayoutTests/platform/mac/editing/style/create-block-for-style-013-expected.txt
    M LayoutTests/platform/mac/editing/style/smoosh-styles-001-expected.txt
    M LayoutTests/platform/mac/editing/style/smoosh-styles-003-expected.txt
    M LayoutTests/platform/mac/editing/style/style-3998892-fix-expected.txt
    M LayoutTests/platform/mac/editing/style/style-boundary-002-expected.txt
    M LayoutTests/platform/mac/editing/style/style-boundary-003-expected.txt
    M LayoutTests/platform/mac/editing/style/style-boundary-004-expected.txt
    M LayoutTests/platform/mac/editing/style/style-boundary-005-expected.txt
    M LayoutTests/platform/mac/editing/unsupported-content/list-delete-001-expected.txt
    M LayoutTests/platform/mac/editing/unsupported-content/list-delete-003-expected.txt
    M LayoutTests/platform/mac/editing/unsupported-content/list-type-after-expected.txt
    M LayoutTests/platform/mac/editing/unsupported-content/list-type-before-expected.txt
    M LayoutTests/platform/mac/editing/unsupported-content/table-delete-002-expected.txt
    M LayoutTests/platform/mac/editing/unsupported-content/table-type-after-expected.txt
    M LayoutTests/platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.txt
    M LayoutTests/platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt
    M LayoutTests/platform/mac/fast/css-generated-content/table-row-with-before-expected.txt
    M LayoutTests/platform/mac/fast/css-generated-content/table-with-before-expected.txt
    M LayoutTests/platform/mac/fast/css/font-smoothing-expected.txt
    M LayoutTests/platform/mac/fast/css/outline-narrowLine-expected.txt
    M LayoutTests/platform/mac/fast/css/rtl-ordering-expected.txt
    M LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt
    M LayoutTests/platform/mac/fast/css/text-rendering-expected.txt
    M LayoutTests/platform/mac/fast/css/word-space-extra-expected.txt
    M LayoutTests/platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt
    M LayoutTests/platform/mac/fast/dynamic/selection-highlight-adjust-expected.txt
    M LayoutTests/platform/mac/fast/encoding/utf-16-big-endian-expected.txt
    M LayoutTests/platform/mac/fast/encoding/utf-16-little-endian-expected.txt
    M LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.txt
    M LayoutTests/platform/mac/fast/forms/placeholder-position-expected.txt
    M LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.txt
    M LayoutTests/platform/mac/fast/forms/select-initial-position-expected.txt
    M LayoutTests/platform/mac/fast/forms/select-style-expected.txt
    M LayoutTests/platform/mac/fast/forms/select/optgroup-rendering-expected.txt
    M LayoutTests/platform/mac/fast/forms/textarea-align-expected.txt
    M LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt
    M LayoutTests/platform/mac/fast/images/image-map-anchor-children-expected.txt
    M LayoutTests/platform/mac/fast/inline/positionedLifetime-expected.txt
    M LayoutTests/platform/mac/fast/layers/layer-visibility-sublayer-expected.txt
    M LayoutTests/platform/mac/fast/text/basic/012-expected.txt
    M LayoutTests/platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt
    M LayoutTests/platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt
    M LayoutTests/platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt
    M LayoutTests/platform/mac/fast/writing-mode/basic-vertical-line-expected.txt
    M LayoutTests/platform/mac/fast/writing-mode/basic-vertical-line-mixed-expected.txt
    M LayoutTests/platform/mac/fast/writing-mode/english-lr-text-expected.txt
    M LayoutTests/platform/mac/fast/writing-mode/fieldsets-expected.txt
    M LayoutTests/platform/mac/fonts/monospace-expected.txt
    M LayoutTests/platform/mac/fonts/sans-serif-expected.txt
    M LayoutTests/platform/mac/fonts/serif-expected.txt
    M LayoutTests/platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt
    M LayoutTests/platform/mac/platform/mac/scrollbars/key-window-not-first-responder-expected.txt
    M LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-1-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug28928-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug6404-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/core/bloomberg-expected.txt
    M LayoutTests/platform/mac/transforms/3d/general/perspective-units-expected.txt
    M LayoutTests/platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt
    M LayoutTests/printing/iframe-print-expected.txt
    M LayoutTests/tables/table-col-indent-crash-expected.txt
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [Quirks mode only] "Do not trim trailing whitespace followed by <br>" quirk causes lines to stretch
https://bugs.webkit.org/show_bug.cgi?id=139199

Reviewed by Antti Koivisto.

Remove legacy quirk (now we match blink and gecko).

(table-col-indent-crash.html change is specific to -webkit-user-modify)

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.cpp:
(WebCore::Layout::InlineFormattingQuirks::shouldPreserveTrailingWhitespace const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::close):

Canonical link: https://commits.webkit.org/263291@main

More information about the webkit-changes mailing list