[webkit-changes] [WebKit/WebKit] c793c7: Web Inspector: Fonts: Holding down arrow up/down k...

[Razvan Caliman - Apple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c793c7c08a44ac518407dc80de56791a080cadc7
      https://github.com/WebKit/WebKit/commit/c793c7c08a44ac518407dc80de56791a080cadc7
  Author: Razvan Caliman <rcaliman at apple.com>
  Date:   2023-04-22 (Sat, 22 Apr 2023)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.js

  Log Message:
  -----------
  Web Inspector: Fonts: Holding down arrow up/down keys in the variation axis input field does not update the CSS value
https://bugs.webkit.org/show_bug.cgi?id=255822

Reviewed by Patrick Angle.

The "input" event handler for the variation axis input field dispatches
the `WI.FontVariationDetailsSectionRow.Event.VariationValueChanged` event.
In response to that, the variation axis value is written to the node's inline styles.

Pressing `ArrowUp` and `ArrowDown` keys in an `<input type="text">` field
will not dispatch "input" DOM events. Therefore, the handler never gets invoked.

This didn't occur when we were using `<input type="number">`, but we switched
away from that because it didn't reject invalid values or support the ergonomics we needed.

To fix this, we now dispatch the `WI.FontVariationDetailsSectionRow.Event.VariationValueChanged`
from the "keydown" event handler when the gesture indicates an action to change the value using arrow keys.

* Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.js:
(WI.FontVariationDetailsSectionRow.prototype._handleValueTextFieldKeydown):

Canonical link: https://commits.webkit.org/263278@main