[webkit-changes] [WebKit/WebKit] e07c0d: The status for the PushAPIEnabled flag should be '...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e07c0d836e7a36a5eed02469e76966513e3f263a
      https://github.com/WebKit/WebKit/commit/e07c0d836e7a36a5eed02469e76966513e3f263a
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Tools/DumpRenderTree/TestOptions.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
    M Tools/WebKitTestRunner/TestOptions.cpp

  Log Message:
  -----------
  The status for the PushAPIEnabled flag should be 'embedder' rather than 'testable'
https://bugs.webkit.org/show_bug.cgi?id=255794
<rdar://problem/108375647>

Reviewed by Ben Nham.

While reviewing feature flag state, we noticed that 'PushAPIEnabled' is testable (and
off-by-default). It should instead be an `embedder` flag.

We should continue to activate it during tests to maintain proper coverage.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Tools/DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
* Tools/WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):

Canonical link: https://commits.webkit.org/263267@main