[webkit-changes] [WebKit/WebKit] 1eb0aa: Web Inspector: Console: timestamps are always wrong

Devin Rousso noreply at github.com
Fri Apr 21 13:20:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1eb0aa379232623c10a39b940d5e2ddf594ed5d2
      https://github.com/WebKit/WebKit/commit/1eb0aa379232623c10a39b940d5e2ddf594ed5d2
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
    A LayoutTests/inspector/console/timestamp-expected.txt
    A LayoutTests/inspector/console/timestamp.html
    M Source/JavaScriptCore/inspector/ConsoleMessage.cpp
    M Source/JavaScriptCore/inspector/ConsoleMessage.h
    M Source/WebCore/page/PageConsoleClient.cpp

  Log Message:
  -----------
  Web Inspector: Console: timestamps are always wrong
https://bugs.webkit.org/show_bug.cgi?id=255033

Reviewed by Patrick Angle.

Use `WallTime` instead of `Monotonic` time since this is a timestamp we expect to display rather than something for comparison (i.e. "was this before that?").

* Source/JavaScriptCore/inspector/ConsoleMessage.h:
* Source/JavaScriptCore/inspector/ConsoleMessage.cpp:
(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::addToFrontend):
(Inspector::ConsoleMessage::updateRepeatCountInConsole):
* Source/WebCore/page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::screenshot):

* LayoutTests/inspector/console/timestamp.html: Added.
* LayoutTests/inspector/console/timestamp-expected.txt: Added.

Canonical link: https://commits.webkit.org/263261@main




More information about the webkit-changes mailing list