[webkit-changes] [WebKit/WebKit] dc4c47: [WPE][GTK] Do not deref CreationData's buffer when...

Vitaly Dyachkov noreply at github.com
Fri Apr 21 12:45:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc4c470f94712dacd9dbd7562798e642f3003eb7
      https://github.com/WebKit/WebKit/commit/dc4c470f94712dacd9dbd7562798e642f3003eb7
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/Font.h
    M Source/WebCore/platform/graphics/FontCustomPlatformData.h
    M Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp

  Log Message:
  -----------
  [WPE][GTK] Do not deref CreationData's buffer when Cairo font is destroyed
https://bugs.webkit.org/show_bug.cgi?id=255785

Reviewed by Carlos Alberto Lopez Perez.

Since 263084 at main `FontCustomPlatformData` takes
`FontPlatformData::CreationData` instead of `FragmentedSharedBuffer`.
The buffer is now a reference counted field of
`FontPlatformData::CreationData` struct and will be automatically
dereferenced when `FontCustomPlatformData` is destroyed.
It is an error to manually dereference it using Cairo font destroy
function.

* Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::releaseCustomFontData): Deleted.

Canonical link: https://commits.webkit.org/263258@main




More information about the webkit-changes mailing list