[webkit-changes] [WebKit/WebKit] c7a661: Partial Sync SVGAnimationElement.idl with IDL Spec

Ahmad Saleem noreply at github.com
Fri Apr 21 11:21:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7a661464e1fe2ba634157ac3b4ee756728be7a6
      https://github.com/WebKit/WebKit/commit/c7a661464e1fe2ba634157ac3b4ee756728be7a6
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
    M LayoutTests/svg/custom/elementTimeControl-nan-crash.html
    A LayoutTests/svg/dom/SVGAnimationElement-begin-end-arguments-typechecks-expected.txt
    A LayoutTests/svg/dom/SVGAnimationElement-begin-end-arguments-typechecks.html
    M Source/WebCore/svg/SVGAnimationElement.cpp
    M Source/WebCore/svg/SVGAnimationElement.idl

  Log Message:
  -----------
  Partial Sync SVGAnimationElement.idl with IDL Spec

https://bugs.webkit.org/show_bug.cgi?id=250575
rdar://problem/104475517

Reviewed by Said Abou-Hallawa.

This patch is to align WebKit with web-spec [1].

[1]: https://svgwg.org/specs/animations/#InterfaceSVGAnimationElement

Cherry-Pick: https://src.chromium.org/viewvc/blink?revision=171485&view=revision &
https://src.chromium.org/viewvc/blink?view=revision&revision=190359

This patch aligns WebKit with web-specification by dropping unnecessary NaN
and remove 'optional' and 'unrestricted' from IDL file as needed.

* Source/WebCore/svg/SVGAnimationElement.cpp:
(SVGAnimationElement::beginElementAt): Remove early return for 'nan' values
(SVGAnimationElement::endElementAt): Ditto
* Source/WebCore/svg/SVGAnimationElement.idl: Align with web-spec
* LayoutTests/svg/custom/elementTimeControl-nan-crash.html: Updated to Dump Text
* LayoutTests/svg/dom/SVGAnimationElement-begin-end-arguments-typechecks.html: Add Testcase
* LayoutTests/svg/dom/SVGAnimationElement-begin-end-arguments-typechecks-expected.txt: Add Testcase Expectation

Canonical link: https://commits.webkit.org/263253@main




More information about the webkit-changes mailing list