[webkit-changes] [WebKit/WebKit] 3f549d: AX: aria-grabbed and aria-dropeffects don't work f...

Tyler Wilcock noreply at github.com
Fri Apr 21 10:17:46 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f549dfda7946f5b554aa8c45da58e0fb97871aa
      https://github.com/WebKit/WebKit/commit/3f549dfda7946f5b554aa8c45da58e0fb97871aa
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
    M LayoutTests/accessibility/mac/aria-drag-drop-expected.txt
    M LayoutTests/accessibility/mac/aria-drag-drop.html
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.h

  Log Message:
  -----------
  AX: aria-grabbed and aria-dropeffects don't work for display:contents elements
https://bugs.webkit.org/show_bug.cgi?id=255757
rdar://problem/108349820

Reviewed by Chris Fleizach.

Fix this by moving the necessary implementations from
AccessibilityRenderObject to AccessibilityNodeObject.

* LayoutTests/accessibility/mac/aria-drag-drop-expected.txt:
* LayoutTests/accessibility/mac/aria-drag-drop.html:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsDropping const):
(WebCore::AccessibilityNodeObject::supportsDragging const):
(WebCore::AccessibilityNodeObject::isGrabbed):
(WebCore::AccessibilityNodeObject::determineDropEffects const):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::supportsDropping const): Deleted.
(WebCore::AccessibilityRenderObject::supportsDragging const): Deleted.
(WebCore::AccessibilityRenderObject::isGrabbed): Deleted.
(WebCore::AccessibilityRenderObject::determineDropEffects const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:

Canonical link: https://commits.webkit.org/263249@main




More information about the webkit-changes mailing list