[webkit-changes] [WebKit/WebKit] 057b73: [WPE] Make TouchPoint ID unique

Bastian Krause noreply at github.com
Fri Apr 21 06:28:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 057b735cbf912f620273106541f2196191c5aa53
      https://github.com/WebKit/WebKit/commit/057b735cbf912f620273106541f2196191c5aa53
  Author: Bastian Krause <bst at pengutronix.de>
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
    M Source/WebKit/Shared/libwpe/WebEventFactory.cpp

  Log Message:
  -----------
  [WPE] Make TouchPoint ID unique
https://bugs.webkit.org/show_bug.cgi?id=214865

Reviewed by Michael Catanzaro.

The web uses a unique touch point id. A few touch controllers reporting
a unique ID by ABS_MT_TRACKING_ID [1] but libinput and the wayland-protocol
don't take this information into account. Fix this within WebKit to be
independent of libinput, the wayland-protocol and a wayland-compositor.

This affects TouchEvents in WPE. It will also affect PointerEvents which
will be implemented in a future PR.

Initial patch version by Marco Felsch <m.felsch at pengutronix.de>, tested
and improved by Bastian Krause <bst at pengutronix.de>.

* Source/WebKit/Shared/libwpe/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebTouchEvent): Return a WebTouchEvent
with unique WebPlatformTouchPoints by simply incrementing a static id
starting at 2 (1 being WebCore::mousePointerID).

Canonical link: https://commits.webkit.org/263237@main




More information about the webkit-changes mailing list