[webkit-changes] [WebKit/WebKit] 204cc1: AX: CSS speak-as, AXAccessKey, aria-owns, and URL ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 204cc1e1e3a384a40bed51c2bd73cbe4df86b1fe
      https://github.com/WebKit/WebKit/commit/204cc1e1e3a384a40bed51c2bd73cbe4df86b1fe
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    A LayoutTests/accessibility/display-contents-aria-owns-expected.txt
    A LayoutTests/accessibility/display-contents-aria-owns.html
    M LayoutTests/accessibility/mac/accesskey-expected.txt
    M LayoutTests/accessibility/mac/accesskey.html
    M LayoutTests/accessibility/mac/css-speech-speak-expected.txt
    M LayoutTests/accessibility/mac/css-speech-speak.html
    M LayoutTests/accessibility/url-test-expected.txt
    M LayoutTests/accessibility/url-test.html
    A LayoutTests/platform/glib/accessibility/display-contents-aria-owns-expected.txt
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AccessibilityImageMapLink.cpp
    M Source/WebCore/accessibility/AccessibilityImageMapLink.h
    M Source/WebCore/accessibility/AccessibilityMenuListOption.cpp
    M Source/WebCore/accessibility/AccessibilityMenuListOption.h
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  -----------
  AX: CSS speak-as, AXAccessKey, aria-owns, and URL AX APIs don't work for display:contents elements
https://bugs.webkit.org/show_bug.cgi?id=255707
rdar://problem/108301432

Reviewed by Chris Fleizach and Andres Gonzalez.

Move implementations from AccessibilityRenderObject to the appropriate base class.

This patch also removes unused MSAA functions.

This patch also fixes a bug where AXPropertyName::AccessKey was not updated for isolated objects when the accesskey attribute changed.

* LayoutTests/accessibility/display-contents-aria-owns-expected.txt: Added.
* LayoutTests/accessibility/display-contents-aria-owns.html: Added.

* LayoutTests/accessibility/mac/accesskey-expected.txt:
* LayoutTests/accessibility/mac/accesskey.html:
Add display:contents testcase.
Add dynamic attribute change testcase.

* LayoutTests/accessibility/mac/css-speech-speak-expected.txt:
* LayoutTests/accessibility/mac/css-speech-speak.html:
* LayoutTests/accessibility/url-test-expected.txt:
* LayoutTests/accessibility/url-test.html:
Add display:contents testcase.

* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::stringValueForMSAA const): Deleted.
(WebCore::AccessibilityImageMapLink::nameForMSAA const): Deleted.
* Source/WebCore/accessibility/AccessibilityImageMapLink.h:
* Source/WebCore/accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::nameForMSAA const): Deleted.
* Source/WebCore/accessibility/AccessibilityMenuListOption.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::url const):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessKey const):
(WebCore::AccessibilityObject::speakAsProperty const):
(WebCore::AccessibilityObject::supportsARIAOwns const):
(WebCore::AccessibilityObject::loadingProgress const):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::stringValueForMSAA const): Deleted.
(WebCore::AccessibilityObject::stringRoleForMSAA const): Deleted.
(WebCore::AccessibilityObject::nameForMSAA const): Deleted.
(WebCore::AccessibilityObject::descriptionForMSAA const): Deleted.
(WebCore::AccessibilityObject::roleValueForMSAA const): Deleted.
(WebCore::AccessibilityObject::speakAsProperty const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::url const):
(WebCore::AccessibilityRenderObject::speakAsProperty const): Deleted.
(WebCore::AccessibilityRenderObject::loadingProgress const): Deleted.
(WebCore::AccessibilityRenderObject::accessKey const): Deleted.
(WebCore::AccessibilityRenderObject::supportsARIAOwns const): Deleted.
(WebCore::isLinkable): Deleted.
(WebCore::AccessibilityRenderObject::stringValueForMSAA const): Deleted.
(WebCore::AccessibilityRenderObject::nameForMSAA const): Deleted.
(WebCore::shouldReturnTagNameAsRoleForMSAA): Deleted.
(WebCore::AccessibilityRenderObject::stringRoleForMSAA const): Deleted.
(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA const): Deleted.
(WebCore::AccessibilityRenderObject::descriptionForMSAA const): Deleted.
(WebCore::msaaRoleForRenderer): Deleted.
(WebCore::AccessibilityRenderObject::roleValueForMSAA const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):

Canonical link: https://commits.webkit.org/263205@main