[webkit-changes] [WebKit/WebKit] ed62cd: Implement isFullWebBrowser check on macOS

Sihui noreply at github.com
Thu Apr 20 14:22:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed62cd603fa0941eca6db6fc2ad512ca473690cb
      https://github.com/WebKit/WebKit/commit/ed62cd603fa0941eca6db6fc2ad512ca473690cb
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    M Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.h
    M Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm
    M Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp
    M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Implement isFullWebBrowser check on macOS
https://bugs.webkit.org/show_bug.cgi?id=255668
rdar://108271078

Reviewed by Per Arne Vollan.

isFullWebBrowser() is available on Cocoa platforms but only returns meaningful value on non-macOS platforms, because it
is implemented by checking an entitlement that is not avaiable on macOS. This patch implements the check on macOS. To
avoid breakage, this patch does not change any behaivor, by ensuring the existing callsites get the same value as before
this patch.

Also, `isFullWebBrowser()` actually returns true when app is browser *or* test app, so this patch renames it to
`isFullWebBrowserOrRunningTest()`.

* Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.h:
* Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:
(WebKit::determineTrackingPreventionStateInternal):
(WebKit::isFullWebBrowserOrRunningTest):
(WebKit::isFullWebBrowser): Deleted.
* Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::filterAppBoundCookies):
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadSimulatedRequest):
(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomainAndCheckIfPermitted):

Canonical link: https://commits.webkit.org/263198@main




More information about the webkit-changes mailing list