[webkit-changes] [WebKit/WebKit] a44713: [Win] WTF::RunLoop: RegisterClass has to be called...

Fujii Hironori noreply at github.com
Thu Apr 20 14:04:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a44713b31e5629dd1c3d750b74603116436bbc6b
      https://github.com/WebKit/WebKit/commit/a44713b31e5629dd1c3d750b74603116436bbc6b
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    M Source/WTF/wtf/win/MainThreadWin.cpp
    M Source/WTF/wtf/win/RunLoopWin.cpp

  Log Message:
  -----------
  [Win] WTF::RunLoop: RegisterClass has to be called in the main thread before creating other threads
https://bugs.webkit.org/show_bug.cgi?id=255624

Reviewed by Don Olmstead.

CreateWindow was randomly failing in the GPU process for WebGL tests
for Windows port. This seems to be a theading issue of calling
CreateWindow in a different thread rather than one called
RegisterClass. RegisterClass has to be called in the main thread
before creating other threads. Reverted 228617 at main.

* Source/WTF/wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform):
* Source/WTF/wtf/win/RunLoopWin.cpp:
(WTF::RunLoop::registerRunLoopMessageWindowClass):
(WTF::RunLoop::RunLoop):

Canonical link: https://commits.webkit.org/263194@main




More information about the webkit-changes mailing list