[webkit-changes] [WebKit/WebKit] 5b1d7c: Stop marking isInvalidInputType() as friend to Inp...

Chris Dumez noreply at github.com
Thu Apr 20 10:19:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b1d7c2431023876aa2cdc4035877580a48396ef
      https://github.com/WebKit/WebKit/commit/5b1d7c2431023876aa2cdc4035877580a48396ef
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    M Source/WebCore/html/BaseDateAndTimeInputType.h
    M Source/WebCore/html/ButtonInputType.h
    M Source/WebCore/html/CheckboxInputType.h
    M Source/WebCore/html/ColorInputType.h
    M Source/WebCore/html/DateInputType.h
    M Source/WebCore/html/DateTimeLocalInputType.h
    M Source/WebCore/html/EmailInputType.h
    M Source/WebCore/html/FileInputType.h
    M Source/WebCore/html/HiddenInputType.h
    M Source/WebCore/html/ImageInputType.h
    M Source/WebCore/html/InputType.cpp
    M Source/WebCore/html/InputType.h
    M Source/WebCore/html/MonthInputType.h
    M Source/WebCore/html/NumberInputType.h
    M Source/WebCore/html/PasswordInputType.h
    M Source/WebCore/html/RadioInputType.h
    M Source/WebCore/html/RangeInputType.h
    M Source/WebCore/html/ResetInputType.h
    M Source/WebCore/html/SearchInputType.h
    M Source/WebCore/html/SubmitInputType.h
    M Source/WebCore/html/TelephoneInputType.h
    M Source/WebCore/html/TextInputType.h
    M Source/WebCore/html/TimeInputType.h
    M Source/WebCore/html/URLInputType.h
    M Source/WebCore/html/WeekInputType.h

  Log Message:
  -----------
  Stop marking isInvalidInputType() as friend to InputType subclasses
https://bugs.webkit.org/show_bug.cgi?id=255731

Reviewed by Darin Adler.

Stop marking isInvalidInputType() as friend to InputType subclasses. We just
need to make a few validation function public (which they are already in the
base class). This allows us to move isInvalidInputType() to InputType.cpp,
since this is the only place it is used.

* Source/WebCore/html/BaseDateAndTimeInputType.h:
* Source/WebCore/html/ButtonInputType.h:
* Source/WebCore/html/CheckboxInputType.h:
* Source/WebCore/html/ColorInputType.h:
* Source/WebCore/html/DateInputType.h:
* Source/WebCore/html/DateTimeLocalInputType.h:
* Source/WebCore/html/EmailInputType.h:
* Source/WebCore/html/FileInputType.h:
* Source/WebCore/html/HiddenInputType.h:
* Source/WebCore/html/ImageInputType.h:
* Source/WebCore/html/InputType.cpp:
(WebCore::isInvalidInputType):
(WebCore::InputType::typeMismatchFor const): Deleted.
(WebCore::InputType::typeMismatch const): Deleted.
(WebCore::InputType::valueMissing const): Deleted.
(WebCore::InputType::hasBadInput const): Deleted.
(WebCore::InputType::patternMismatch const): Deleted.
* Source/WebCore/html/InputType.h:
(WebCore::InputType::typeMismatchFor const):
(WebCore::InputType::valueMissing const):
(WebCore::InputType::hasBadInput const):
(WebCore::InputType::patternMismatch const):
(WebCore::InputType::typeMismatch const):
(WebCore::isInvalidInputType): Deleted.
* Source/WebCore/html/MonthInputType.h:
* Source/WebCore/html/NumberInputType.h:
* Source/WebCore/html/PasswordInputType.h:
* Source/WebCore/html/RadioInputType.h:
* Source/WebCore/html/RangeInputType.h:
* Source/WebCore/html/ResetInputType.h:
* Source/WebCore/html/SearchInputType.h:
* Source/WebCore/html/SubmitInputType.h:
* Source/WebCore/html/TelephoneInputType.h:
* Source/WebCore/html/TextInputType.h:
* Source/WebCore/html/TimeInputType.h:
* Source/WebCore/html/URLInputType.h:
* Source/WebCore/html/WeekInputType.h:

Canonical link: https://commits.webkit.org/263179@main




More information about the webkit-changes mailing list