[webkit-changes] [WebKit/WebKit] 127ea0: [Line-clamp] heightForLineCount should use modern ...

Alan Baradlay noreply at github.com
Thu Apr 20 07:29:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 127ea0db1d3b7e939c807dadb3f2f2ec2704f54c
      https://github.com/WebKit/WebKit/commit/127ea0db1d3b7e939c807dadb3f2f2ec2704f54c
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp

  Log Message:
  -----------
  [Line-clamp] heightForLineCount should use modern iterator interface
https://bugs.webkit.org/show_bug.cgi?id=255667

Reviewed by Antti Koivisto.

This is in preparation for taking heightForLineCount into use for the modern line clamp codepath.

* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::getHeightForLineCount):
(WebCore::heightForLineCount): getHeightForLineCount already returns null_opt for cases like this. We just ensure here that both getHeightForLineCount and heightForLineCount have the same semantics.

(WebCore::RenderDeprecatedFlexibleBox::applyModernLineClamp): rename
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp): rename

Canonical link: https://commits.webkit.org/263173@main




More information about the webkit-changes mailing list