[webkit-changes] [WebKit/WebKit] 02cdac: Assertion failure in createWebViewWithRequest when...

Ryosuke Niwa noreply at github.com
Wed Apr 19 17:04:38 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02cdac5e408458239c489b1a2c57a3b858f9041c
      https://github.com/WebKit/WebKit/commit/02cdac5e408458239c489b1a2c57a3b858f9041c
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-04-19 (Wed, 19 Apr 2023)

  Changed paths:
    M Tools/DumpRenderTree/mac/UIDelegate.mm

  Log Message:
  -----------
  Assertion failure in createWebViewWithRequest when running imported/w3c/web-platform-tests/shadow-dom/crashtests/move-to-new-tree-1343016.html
https://bugs.webkit.org/show_bug.cgi?id=255665

Reviewed by Chris Dumez.

The assertion failure is caused by the test using "test-wait" attribute on the document element
to make the test keep running instead of calling waitUntilDone(). Fixed the bug by relaxing
the assertion to allow this method of waiting.

* Tools/DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:createWebViewWithRequest:]):

Canonical link: https://commits.webkit.org/263156@main




More information about the webkit-changes mailing list