[webkit-changes] [WebKit/WebKit] ee46c7: [iOS] Make eager soft-linking of Data Detection fr...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee46c752943bd6be0e433b8e7931efd5de456e77
      https://github.com/WebKit/WebKit/commit/ee46c752943bd6be0e433b8e7931efd5de456e77
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2023-04-19 (Wed, 19 Apr 2023)

  Changed paths:
    M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
    M Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISPI.h
    A Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISoftLink.h
    A Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISoftLink.mm
    M Source/WebCore/editing/cocoa/DataDetection.mm
    M Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  -----------
  [iOS] Make eager soft-linking of Data Detection frameworks non-fatal
https://bugs.webkit.org/show_bug.cgi?id=255369
<rdar://107752677>

Reviewed by David Kilzer.

Eager soft-linking of the Data Detection framework was added in Bug 241267.

Crash telemetry indicates that the soft-linking fails in some cases, possibly
when multiple code paths are trying to initialize the DataDetectors framework,
and one of those paths fails

Instead, we should consolidate the SoftLink code into a single implementation
file, and use that single code path in all cases.

* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISPI.h: Moved some declarations
to DataDetectorsUISoftLink.
* Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISoftLink.h: Added.
* Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISoftLink.mm: Added.
* Source/WebCore/editing/cocoa/DataDetection.mm: Reference new SoftLink calls.
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: Ditto.
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::softlinkDataDetectorsFrameworks): Ditto.

Canonical link: https://commits.webkit.org/263154@main