[webkit-changes] [WebKit/WebKit] aa1ea2: createImageBitmap using ImageData doesn't respect ...

mattwoodrow noreply at github.com
Wed Apr 19 10:59:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa1ea27b114e05e0d19fdb76d22c39e88600917f
      https://github.com/WebKit/WebKit/commit/aa1ea27b114e05e0d19fdb76d22c39e88600917f
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2023-04-19 (Wed, 19 Apr 2023)

  Changed paths:
    M LayoutTests/webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-2d-with-image-bitmap-from-image-data.js
    M Source/WebCore/html/ImageBitmap.cpp

  Log Message:
  -----------
  createImageBitmap using ImageData doesn't respect the premultiply flag.
https://bugs.webkit.org/show_bug.cgi?id=237082
<rdar://89382358>

Reviewed by Brent Fulgham.

This path used the flag to premultiply the incoming data, but didn't mark the resulting ImageBitmap as wanting premultiplied data.
When uploading a WebGL texture we'd check for the flag, and unpremultiply again since it wasn't there.

* LayoutTests/webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-2d-with-image-bitmap-from-image-data.js:
(init):
(generateTest):
* Source/WebCore/html/ImageBitmap.cpp:
(WebCore::ImageBitmap::createPromise):

Canonical link: https://commits.webkit.org/263137@main




More information about the webkit-changes mailing list