[webkit-changes] [WebKit/WebKit] c94b36: [GStreamer] Critical warnings when browsing cnn.com

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c94b3642944f7b606e8d32c196f91e2875eea54b
      https://github.com/WebKit/WebKit/commit/c94b3642944f7b606e8d32c196f91e2875eea54b
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-04-19 (Wed, 19 Apr 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h
    M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp
    M Source/WebCore/platform/gstreamer/GStreamerElementHarness.h

  Log Message:
  -----------
  [GStreamer] Critical warnings when browsing cnn.com
https://bugs.webkit.org/show_bug.cgi?id=254622

Reviewed by Xabier Rodriguez-Calvar.

Parsing and decoding errors are propagated from the GStreamer element harness to the ImageDecoder.
The cnn.com debug logs indicated the openh264dec was failing to negotiate caps with upstream.

This patch also includes a couple changes in the GStreamerElementHarness, mainly automatic start-up
of chained harnesses in order to avoid potentially racy behaviors in sticky events handling.

* Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
(WebCore::ImageDecoderGStreamer::ImageDecoderGStreamer):
(WebCore::ImageDecoderGStreamer::encodedDataStatus const):
(WebCore::ImageDecoderGStreamer::pushEncodedData):
* Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h:
* Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp:
(WebCore::GStreamerElementHarness::pushStickyEvents):
(WebCore::GStreamerElementHarness::Stream::Stream):
* Source/WebCore/platform/gstreamer/GStreamerElementHarness.h:
(WebCore::GStreamerElementHarness::isStarted const):

Canonical link: https://commits.webkit.org/263134@main